Fusion-Power-Plant-Framework / bluemira

Bluemira is an integrated inter-disciplinary design tool for future fusion reactors. It incorporates several modules, some of which rely on other codes, to carry out a range of typical conceptual fusion reactor design activities.
https://bluemira.readthedocs.io/
GNU Lesser General Public License v2.1
59 stars 16 forks source link

Add toroidal coordinate transform functions, tests and documentation #3418

Closed clmould closed 2 months ago

clmould commented 3 months ago

Linked Issues

Closes #{ID}

Description

Interface Changes

Checklist

I confirm that I have completed the following checks:

geograham commented 2 months ago

I agree with James about the location moves. Code looks good to merge once the files are relocated and the checks are passing.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.12%. Comparing base (3f19183) to head (c09a03f). Report is 8 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3418 +/- ## =========================================== - Coverage 74.64% 74.12% -0.52% =========================================== Files 231 230 -1 Lines 26871 26585 -286 =========================================== - Hits 20058 19707 -351 - Misses 6813 6878 +65 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 months ago

⚠️ Warning Report

Found 0 new warnings, 0 fixed warnings. 🎉

All warnings (6) #### On runtest - `/home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ffcx/element_interface.py:23: DeprecationWarning: Use of elements created by UFL is deprecated. You should create elements directly using Basix.` - `/home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ffcx/element_interface.py:26: DeprecationWarning: Converting elements created in UFL to Basix elements is deprecated. You should create the elements directly using basix.ufl.element instead` - `/home/runner/work/bluemira/bluemira/bluemira/equilibria/optimisation/harmonics/harmonics_approx_functions.py:42: RuntimeWarning: divide by zero encountered in log10` - `/home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ufl/core/expr.py:275: DeprecationWarning: Expr.ufl_domain() is deprecated, please use extract_unique_domain(expr) instead.` - `/home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/basix/ufl.py:1909: DeprecationWarning: Converting elements created in UFL to Basix elements is deprecated. You should create the elements directly using basix.ufl.element instead` #### On collect - `/home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ufl/core/ufl_type.py:56: DeprecationWarning: attach_operators_from_hash_data deprecated, please use UFLObject instead.`
sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud