search

FxMorin / MoreCulling

Stop rendering things you can't see. A mod that changes how multiple types of culling are handled in order to improve performance
https://modrinth.com/mod/moreculling
GNU General Public License v3.0
150 stars 31 forks source link

Vanillatweaks 3d trapdoor model lets one x-ray #125

Closed MeeniMc closed 9 months ago

MeeniMc commented 1 year ago

See trap door in the center. Defect not present with all same setup except removal of MoreCulling

2022-12-31_15 50 57

moreculling-1.19.3-0.12.3 sodium-fabric-mc1.19.3-0.4.7+build.21

Vanilla Tweaks Resource Pack
Version: 1.19
Packs:
    DoubleSlabFix
    ItemHoldFix
    PixelConsistentGhast
    PixelConsistentElderGuardian
    PixelConsistentWither
    ItemStitchingFix
    LiteralGameruleNames
    3DBookshelves
    3DChains
    3DPointedDripstone
    3DAmethyst
    3DTiles
    3DLadders
    3DRails
    3DIronBars
    3DLilyPads
    3DTrapdoors
    3DMushrooms
    3DStonecutters
    3DSunMoon
    3DSugarcane
    3DDoors
    CleanStainedGlass
    CleanTintedGlass
    CleanGlass
    AlternateEnchantGlint
    LowerFire
    LowerShield
    TransparentPumpkin
    NoVignette
    SmallerUtilities
    BuddingAmethystBorders
    VisualInfestedStoneItems
    VisualWaxedCopperItems
    GroovyLevers
    ClearBannerPatterns
    VariatedDirt
    RandomCoarseDirtRotation
    VariatedGrass
    VariatedCobblestone
    RandomMossRotation
    VariatedBricks
    VariatedPlanks
    VariatedMycelium
    VariatedGravel
    VariatedEndStone
    VariatedMushroomBlocks
    VariatedLogs
    VariatedStone
    VariatedTerracotta
    VariatedUnpolishedStones
    CircleLogTops
    FancySunflowers
    ShorterGrass
    ShorterTallGrass
    BetterBedrock
    HDShieldBanners
    UniqueDyes
    AshlessCampfires
    SplashXpBottle
    GoldenCrown
    EnderDragonElytra
    RedIronGolemFlowers
    NoSpyglassOverlay
    AccurateSpyglass

Combined packs:
    AccurateSpyglass+NoSpyglassOverlay
FxMorin commented 1 year ago

I'm not exactly sure why this happens, although I believe its due to the 3D model no longer following the internal cull shape of the block. This is probably not something that vanillatweaks should be doing

FxMorin commented 1 year ago

I'll probably add conditions for custom models at some point. Not sure yet, however you can disable blockstate culling in the settings to temporarily fix this

FxMorin commented 1 year ago

Alright in v0.15.0 its now possible to fix this! https://github.com/fxmorin/MoreCulling/wiki/Resource-Packs

MeeniMc commented 1 year ago

Issue has been resolved with newer VT pack that makes trapdoors thicker.

Naidrox commented 9 months ago

Just ran into this myself today. I'll post a proper issue when I have a bit more time

mpustovoi commented 9 months ago

I still have this issue with v0.22.1 for Fabric 1.20.1 and the newest VT 3D trapdoors (just downloaded the latest) image Maybe I should toggle something in config, idk

FxMorin commented 9 months ago

Im working on a fix

FxMorin commented 9 months ago

Lets keep this closed, the issue is now being followed by: https://github.com/FxMorin/MoreCulling/issues/225