search

FxMorin / MoreCulling

Stop rendering things you can't see. A mod that changes how multiple types of culling are handled in order to improve performance
https://modrinth.com/mod/moreculling
GNU General Public License v3.0
151 stars 32 forks source link

Update to 1.21 #258

Closed CommandGenius closed 4 months ago

CommandGenius commented 4 months ago

1.21 patch for MoreCulling.

wicivo commented 4 months ago

This is a WIP, this does not work yet.

https://mclo.gs/HJZubwq

wicivo commented 4 months ago

Now it's working

Barkells commented 4 months ago

got a compiled jar?

wicivo commented 4 months ago

got a compiled jar?

https://github.com/wicivo/MoreCulling/actions/runs/9664028108

Cartrigger commented 4 months ago

https://github.com/FxMorin/MoreCulling/assets/81428538/93bee8bf-a32e-4862-940d-c3a9160a7c19

Seems like it doesn't like transparency

FxMorin commented 4 months ago

@Cartrigger What do you mean? Like in the mod menu or in game?

Cartrigger commented 4 months ago

https://github.com/FxMorin/MoreCulling/assets/81428538/8d9143c6-8652-4661-baff-615f331f990a

There's blur for the tooltips, I dont think that is intended, because on the right on 1.20.6 it does not happen, though they are both black which may or may not be intended

CommandGenius commented 4 months ago

There's also a bug where holding stained glass on Fabulous graphics makes the stained glass invisible only while holding it. I haven't tested this on 1.20.6.

CommandGenius commented 4 months ago

It looks like it has to do with ItemRenderer_faceCullingMixin.java

ActuallyTheOwner commented 4 months ago

I do see this is waiting approval Hope everything passes!

tajemniktv commented 4 months ago

After some testing I didn't find many issues, mind you I'm playing on a 300+ modpack that mostly modifies the client side (performance, resources, guis, visuals etc.) - I had issues with closed trapdoors, that had their underneath (in the windows) culled, which was basically an X-Ray. Might be worth looking into. Disabling blostate culling helped with that

EDIT: It's... gone by itself? I have to do some testing, but for now it looks issueless EDIT2: Nevermind, I forgot I had blockstates disabled......