search

FxMorin / MoreCulling

Stop rendering things you can't see. A mod that changes how multiple types of culling are handled in order to improve performance
https://modrinth.com/mod/moreculling
GNU General Public License v3.0
140 stars 31 forks source link

Cannot optionally depend on the culling API #285

Open hlysine opened 1 month ago

hlysine commented 1 month ago

Hi, Create: Copycats+ dev here. We have received reports of this mod being incompatible with Copycats+, so I'm trying to implement compat by disabling culling for all our copycats (we already have advanced culling implemented in the block model, so culling done by this mod is redundant). However, because all of MoreCulling's API requires our blocks to implement an interface, I don't think it is possible to optionally depend on this mod, which makes the API unusable since we cannot force all users to download this mod.

Is it possible for other mods to opt out of MoreCulling using something more compatible (e.g. tags)?

FxMorin commented 1 week ago

There are a couple ways: https://github.com/fxmorin/MoreCulling/wiki/Using-the-API Including a tag or config

hlysine commented 1 week ago

I need a tag that disables More Culling in general, since our copycat blocks are neither leaves nor doors.

FxMorin commented 6 days ago

dont_cull is a tag which does that

FxMorin commented 2 days ago

Reminder: List all ways for other mod devs to optionally depend on the culling API