search

G4lile0 / tinyGS

📡 Open Ground Station Network 🛰
GNU General Public License v3.0
923 stars 177 forks source link

Website binary transmission input cannot contain 0s #124

Closed jgromes closed 2 years ago

jgromes commented 2 years ago

It seems that the validation of input on the tinygs.com website doesn't allow zeroes to be entered. For an example, see the screenshot below:

tinygs

In addition, the input text field will attempt to "auto-correct" any zeroes entered, so it's not possible to enter e.g 0x01 0x02 - it will get auto-corrected to 0x12.

PS: I'm not sure if this is the correct place to report this - please let me know if not.

4m1g0 commented 2 years ago

Thanks a lot Jan,

I've made a quick fix and it should be working properly now. Let me know if it's not the case!

jgromes commented 2 years ago

And thank you for the prompt bugfix, it is indeed all OK now.

4m1g0 commented 2 years ago

In case you had more problems with the TX, I've just finally had time to test it and found another bug related to the hex TX, under certain circumstances it was sending a wrong base64 str to the network so the tx string that received the board was not the right one.

It should be fixed now.

jgromes commented 2 years ago

Thanks, I was only using the direct hex input, and didn't notice any issues with that.