search

G4lile0 / tinyGS

📡 Open Ground Station Network 🛰
GNU General Public License v3.0
925 stars 178 forks source link

Prevent buffer overflow in retransmission. Improve WiFi begin connection #20

Closed lillefyr closed 4 years ago

lillefyr commented 4 years ago

Re-transmit a buffer or 32 chars crashes the Groundstation. Limit the input size (or increase the buffer by 1 to make space for the \0, termination)

Lolin32 dev have issues with WiFi connections, a solution suggested generally for ESP32 is to add a WiFi.enableSTA before wifi.begin. Seems to improve the begin connection. Not prefect.

Wait did not happen as test was wrong. It may be necessary to change wait time to 3 seconds instead of 10.

4m1g0 commented 4 years ago

Good catch, thank you.

Regarding the wifi connection we are rebuilding all that part with a new config system and will be released in the next days, but this is good in the meantime.