search

GAVLab / ublox

C++ Static library interfacing ublox GPS receivers using the ublox6 UBX protocol
46 stars 26 forks source link

Integer overflow #13

Open madMAx43v3r opened 6 years ago

madMAx43v3r commented 6 years ago

https://github.com/GAVLab/ublox/blob/22de15b9ca240b4c60495388b292bbecc7a4c601/src/ublox.cpp#L1488 This will fail for packets bigger than 255 bytes. EDIT: Even worse it will dead-lock.

hoytech commented 6 years ago

Also, the try/catch block in that function is superfluous: nothing there can throw.