GC-spigot / AdvancedItems

0 stars 0 forks source link

conditions on DEFENSE not working #29

Open illudota opened 5 months ago

illudota commented 5 months ago

So I found this bug, that this condition im using is not working on DEFENSE trigger on AdvancedItems, im not sure about AdvancedEnchantments and other advanced plugins but yeah

Aitems version: 1.5.2

Video: https://streamable.com/9j1rjk

Effects:

This one doesn't work, since it's DEFENSE, but try removing conditions, it'll work.

DEFENSE:
    conditions: 
    - '%advanceditems helmet type% = ninja1 : %allow%'
    - '%advanceditems chestplate type% = ninja2 : %allow%'
    - '%advanceditems leggings type% = ninja3 : %allow%'
    - '%advanceditems boots type% = ninja4 : %allow%'
    effects:
      - 'POTION:BLINDNESS:0:60 @Attacker'

This works, since it's ATTACK

ATTACK:
    conditions: 
    - '%advanceditems helmet type% = ninja1 : %allow%'
    - '%advanceditems chestplate type% = ninja2 : %allow%'
    - '%advanceditems leggings type% = ninja3 : %allow%'
    - '%advanceditems boots type% = ninja4 : %allow%'
    effects:
      - 'POTION:SPEED:4:60 @Attacker'
illudota commented 5 months ago

EDIT!:

  display: '&8&lNimble'
  description: ""
  applies-to: 'Armor'
  type: 'DEFENSE'
  group: 'EXCLUSIVES'
  applies:
    - ALL_ARMOR
  levels:
    1:
      conditions:
        - '%advanceditems helmet type% = ninja1 : %allow%'
        - '%advanceditems chestplate type% = ninja2 : %allow%'
        - '%advanceditems leggings type% = ninja3 : %allow%'
        - '%advanceditems boots type% = ninja4 : %allow%'
      effects:
        - CANCEL_EVENT
        - PLAY_SOUND:ENTITY_BAT_TAKEOFF:0.7 @Victim

Tried this on AdvancedEnchantments too, this enchant doesn't work as well unless you remove condition.

This condition works though, it seems like advanceditems condition on DEFENSE trigger isn't functional

nimble:
  display: '&8&lNimble'
  description: ""
  applies-to: 'Armor'
  type: 'DEFENSE'
  group: 'EXCLUSIVES'
  applies:
    - ALL_ARMOR
  levels:
    1:
      conditions:
        - '%victim health% > 15 : %stop%'
      effects:
        - CANCEL_EVENT
        - PLAY_SOUND:ENTITY_BAT_TAKEOFF:0.7 @Victim
illudota commented 5 months ago

up please

illudota commented 4 months ago

Fix please its been 2 weeks despite being bug confirmed. https://github.com/GC-spigot/AdvancedEnchantments/issues/4046

GC-spigot commented 4 months ago

Looking into this

GC-spigot commented 4 months ago

Have you tried making the conditions for victim? e.g. - '%victim advanceditems helmet type% = ninja1 : %allow%'

illudota commented 4 months ago
  • '%victim advanceditems helmet type% = ninja1 : %allow%'

WORKED! thank you!