GCTC-NTGC / gc-digital-talent

GC Digital Talent is the new recruitment platform for digital and tech jobs in the Government of Canada. // Talents numériques du GC est la nouvelle plateforme de recrutement pour les emplois numériques et technologiques au gouvernement du Canada.
https://talent.canada.ca
GNU Affero General Public License v3.0
22 stars 9 forks source link

✨ Remove possibility of setting `PoolCandidate` status directly #10218

Open tristan-orourke opened 7 months ago

tristan-orourke commented 7 months ago

✨ Feature

PoolCandidates should move through states in a guided way, like a state machine (see #9149). Now that we have the UI for doing so, we should remove the controls that let admins choose and update PoolCandidate.status directly.

🕵️ Details

Remove any UI that allows users to select PoolCandidate.status from a dropdown and save it. Delete updatePoolCandidateStatus and any references to it. (Where it was used to update expiry date, we should be able to use qualifyCandidate instead.)

🎨 Design File

I know this needs to be removed from the candidate page. Its possible these controls appear elsewhere as well.

🧑‍🎨 Designer

@Jerryescandon

📸 Screenshot

Note: the figma design does not include the form to directly set status, as it was always meant to be temporary. image

🙋‍♀️ Proposed Implementation

(optional) Do you have a proposed implementation?

✅ Acceptance Criteria

A set of assumptions which, when tested, verify that the feature was properly implemented.

🛑 Blockers

Issues which must be completed before this one.

### Blocked By
- [ ] #9198 
- [ ] #9197 
- [ ] #9140
github-actions[bot] commented 7 months ago

Status: Ready to merge :heavy_check_mark:

Issues blocking this PR:

brindasasi commented 5 months ago

We want to wait on this feature. We will come back if this is required to implement