search

GCTC-NTGC / gc-digital-talent

GC Digital Talent is the new recruitment platform for digital and tech jobs in the Government of Canada. // Talents numériques du GC est la nouvelle plateforme de recrutement pour les emplois numériques et technologiques au gouvernement du Canada.
https://talent.canada.ca
GNU Affero General Public License v3.0
21 stars 8 forks source link

🐛 Disqualified candidates in result for staffing request #10740

Open gobyrne opened 3 months ago

gobyrne commented 3 months ago

Details

When viewing some talent search requests, some expected filters are not being added right away.

Steps to reproduce

  1. Navigate to Talent request table
  2. Filter the table by ANY workstream (no idea why, but we are only able to reproduce when we filter by workstream)
  3. Refresh the page
  4. Click on one of the talent requests
  5. Notice there are only 2 filters (this is the bug) and some disqualified candidates are showing up
  6. Click the back button to go back to the requests page
  7. Click on the SAME talent request again.
  8. Notice there are now 7 filters (or so) and only qualified candidates are showing up

Screenshots

Applicant filter data not coming through on failed try: Image

Successful try looks like this instead: Image

Proposed solution

??

Acceptance criteria

  1. Candidates table should only show Qualified Available candidates by default.
  2. Candidate table filters should be preset as per the given request
brindasasi commented 3 months ago

I suspect there is something with the refresh thing. When you open the page for the first time and navigate to that request it looks right. When you add a filter , it refreshes the page and that's when it loses the filter. Now you click the request link , it shows up only with 2 filters and qualified available filter isn't there.

vd1992 commented 3 months ago

Somehow, the stream filtering from the prior page is being appended onto the URL

image

If you get rid of it things work normally, so the URL part of the component is acting odd. Finding it a bit flaky to replicate, sometimes refreshing the requests table (step 3) prevents it from happening sometimes it doesn't

petertgiles commented 2 months ago

Looks like this got moved to "Read for Dev" without an estimate.

petertgiles commented 2 months ago

I can't reliably reproduce this issue. 😢 I did notice that sometimes the filters can get erroneously carried across to the user table, too.

vd1992 commented 2 months ago

Huh, checked again and am struggling to replicate the issue 🤷

brindasasi commented 2 months ago

oh we didn't estimate it ,.. my bad .. moving back to ready for estimate

brindasasi commented 2 months ago

Huh, checked again and am struggling to replicate the issue 🤷

I haven't tried local though.. UAT & prod we could consistently re-produce. Will try in local sometime later today.

brindasasi commented 2 months ago

Huh, checked again and am struggling to replicate the issue 🤷

I haven't tried local though.. UAT & prod we could consistently re-produce. Will try in local sometime later today.

I'm unable to reproduce this in local and no longer can reproduce in UAT as well. Probably it is fixed. Keep it open until it is confirmed in production.