GCTC-NTGC / gc-digital-talent

GC Digital Talent is the new recruitment platform for digital and tech jobs in the Government of Canada. // Talents numériques du GC est la nouvelle plateforme de recrutement pour les emplois numériques et technologiques au gouvernement du Canada.
https://talent.canada.ca
GNU Affero General Public License v3.0
15 stars 7 forks source link

♻️ Implement cursor based pagination through Lighthouse #10827

Open tristan-orourke opened 1 week ago

tristan-orourke commented 1 week ago

♻️ Debt/Refactor

Lighthouse's pagination directive doesn't offer cursor-based pagination, which would be better in cases where we need to repeat a query until we have all the results (eg infinite scroll).

Insert explanation here of benefits of cursor-based pagination

🕵️ Details

https://github.com/nuwave/lighthouse/issues/311 describes the lack of cursor-based pagination.

We can create a custom directive which works similarly to their paginate directive, but is cursor based instead. We should test it of course, but can wait for a future ticket to actually switch to using it.

🙋‍♀️ Proposed Solution

https://github.com/nuwave/lighthouse/issues/311#issuecomment-1487345645 describes a solution - a custom directive which implements cursor-based scrolling.

🌎 Localization

(optional) Provide any new copy along with translations available.

✅ Acceptance Criteria

brindasasi commented 2 days ago

Could we integrate it with Notification API for testing?