search

GCTC-NTGC / gc-digital-talent

GC Digital Talent is the new recruitment platform for digital and tech jobs in the Government of Canada. // Talents numériques du GC est la nouvelle plateforme de recrutement pour les emplois numériques et technologiques au gouvernement du Canada.
https://talent.canada.ca
GNU Affero General Public License v3.0
22 stars 8 forks source link

[Fix] PHP undefined property errors #11721

Closed esizer closed 1 week ago

esizer commented 1 week ago

🤖 Resolves #11590

👋 Introduction

Fix PHP errors related to access undefined properties.

🕵️ Details

As with all PHPStan PRs, this is mostly just adjusting type hints. As a result, some call to undefined methods were also fixed.

🧪 Testing

  1. Confirm no more instances of undefined property are ignored
  2. Confirm PHPStan check passes
brindasasi commented 1 week ago

looking great and working without any regression. Just a question about the left overs .. other than that good to go ! 👍