search

GCTC-NTGC / gc-digital-talent

GC Digital Talent is the new recruitment platform for digital and tech jobs in the Government of Canada. // Talents numériques du GC est la nouvelle plateforme de recrutement pour les emplois numériques et technologiques au gouvernement du Canada.
https://talent.canada.ca
GNU Affero General Public License v3.0
22 stars 8 forks source link

[Test] Add experience regression test #11752

Open esizer opened 1 week ago

esizer commented 1 week ago

🤖 Resolves #11749

👋 Introduction

Adds a regression test for a previously fixed bug.

[!NOTE] This does not fix the issue as it was already fixed. This is simply adding a regression test for that fix.

Currently only tests work experiences, should we do all different types? :thinking:

🧪 Testing

[!TIP] Reverting the fix means setting the experienceId in the ExperienceFormPage to coalesce to an empty string

experienceId={experienceId ?? ""}

https://github.com/GCTC-NTGC/gc-digital-talent/blob/62e91d475ab8d72281817bf7cb5a9f2c2b1fa64f/apps/web/src/pages/Profile/ExperienceFormPage/ExperienceFormPage.tsx#L685

  1. Confirm test has decent coverage
  2. Confirm test consistently passes
  3. Revert the fix
  4. Confirm test fails
vd1992 commented 1 week ago

Hmm, I think we should probably exercise the experience page a bit more. Not sure if we want to run it for each experience type. I think updating a existing experience as well as linking skills should be tested too

brindasasi commented 22 hours ago

Test works fine but I agree with the comment that the we need to test more on

I'm also ok to get this merged in and work on them as a sep tkt.