search

GCTC-NTGC / gc-digital-talent

GC Digital Talent is the new recruitment platform for digital and tech jobs in the Government of Canada. // Talents numériques du GC est la nouvelle plateforme de recrutement pour les emplois numériques et technologiques au gouvernement du Canada.
https://talent.canada.ca
GNU Affero General Public License v3.0
22 stars 8 forks source link

[Debt] User creation shifted to `authCallback()` #11759

Closed vd1992 closed 4 days ago

vd1992 commented 6 days ago

🤖 Resolves #11466

👋 Introduction

Shift user creation to the callback in AuthController.php Nothing fancy needed to be done

🧪 Testing

  1. Can log in normally with existing user
  2. User creation works
  3. Sign in values updated or set appropriately
  4. Test above with SiC
vd1992 commented 6 days ago

Thank you Larastan, that was indeed something to fix, done in https://github.com/GCTC-NTGC/gc-digital-talent/pull/11759/commits/14e866ebf30fa2f42ae1aac329b06ae3e985188b

vd1992 commented 5 days ago

This works great! I tried it with mock auth and SIC and it works well. 🏅 I'm worried about losing that test, though. This functionality it too important to not have good testing, IMO. Could you rewrite the test for this? Let me know if you want a hand.

Had a nice learning experience and got something in https://github.com/GCTC-NTGC/gc-digital-talent/pull/11759/commits/2169efed5087c8df788a6a3869dc97cda416f80f

vd1992 commented 5 days ago

Not sure what is going on with the PHP test 😕 Works locally