GC Digital Talent is the new recruitment platform for digital and tech jobs in the Government of Canada. // Talents numériques du GC est la nouvelle plateforme de recrutement pour les emplois numériques et technologiques au gouvernement du Canada.
There is now no discernible difference between the root route and admin routes so we can likely move away from them being defined separately.
🕵️ Details
We recently moved all the admin pages over to use a nearly identical layout to the root layout but did not move the routes over so we seem to have a redundant AdminLayout that simply mirrors the main layout.
This also means our route definition has to add in another top level definition for ${locale}/admin that applies the same layout.
I think we should be safe to delete the AdminLayout now and move all the routes to the root route now.
🙋♀️ Proposed Solution
Reorganize the createRoute function to no longer need a separate definition for admin routes
Delete the unused AdminLayout
Possibly remove the admin specific error boundary as well :thinking:
✅ Acceptance Criteria
[ ] Routes under /admin have been moved to the root route definition
♻️ Debt/Refactor
There is now no discernible difference between the root route and admin routes so we can likely move away from them being defined separately.
🕵️ Details
We recently moved all the admin pages over to use a nearly identical layout to the root layout but did not move the routes over so we seem to have a redundant
AdminLayoutthat simply mirrors the main layout.This also means our route definition has to add in another top level definition for
${locale}/adminthat applies the same layout.I think we should be safe to delete the
AdminLayoutnow and move all the routes to the root route now.🙋♀️ Proposed Solution
createRoutefunction to no longer need a separate definition for admin routesAdminLayout✅ Acceptance Criteria
/adminhave been moved to the root route definition