GCTC-NTGC / gc-digital-talent

GC Digital Talent is the new recruitment platform for digital and tech jobs in the Government of Canada. // Talents numériques du GC est la nouvelle plateforme de recrutement pour les emplois numériques et technologiques au gouvernement du Canada.
https://talent.canada.ca
GNU Affero General Public License v3.0
15 stars 7 forks source link

Investigate migrating input elements to the GCDS Stencil components #3750

Open substrae opened 1 year ago

substrae commented 1 year ago

ℹ️ Figma (root) | Sitemap This initial comment is collaborative and open to modification by all.

Description

@tristan-orourke and I discussed potentially collaborating with @ethanWallace and @melaniebmn to pull the form element components into our project as a pilot. These components are built with Stenciljs, are React compatible, and are output as standards-compliant web components.

Components up for grabs that we can consider:

The CDS team is looking for feedback on ease of use (particularly with React), accessibility, architecture and data model structure, and design customization.

Acceptance Criteria

mnigh commented 1 year ago

@tristan-orourke is this still being considered or can it be iceboxed or closed?

substrae commented 1 year ago

We should be looking into doing this with whatever components we can.

mnigh commented 1 year ago

We should be looking into doing this with whatever components we can.

The project is still in alpha in its life cycle though.

Screenshot

Screen Shot 2023-06-06 at 15 06 21

substrae commented 1 year ago

Indeed it is, and they'll never get proper feedback without the implementation support from testers like us!

adorayi commented 1 year ago

I'm the Product Manager on this at CDS, we would love to get your feedback to help shape our roadmap. We are a permanent team dedicated to this work so will continue to support this product, we plan to be out of alpha and into a full release by Spring 2024. I would be happy to meet with your team to share our roadmap and milestones for 2023/24. We expect to add another dozen components to the library by August 2023 to bring us to 24 total.

image

substrae commented 1 year ago

Can confirm, @abdul-CDS will give y'all a fantastic overview and can probably speak to things far better than I can now that so much time has passed. CC @tristan-orourke @gobyrne

tristan-orourke commented 3 months ago

You know what? At this point, I would be pretty comfortable adopting a lot of these components. We could probably replace the implementation of our low-level components with a wrapper of theirs without having to rewrite the whole site.

My biggest question is actually for @substrae - would you be comfortable giving up some control of our component styling to use this library?

substrae commented 3 months ago

@tristan-orourke

Assuming they've maintained the original vision, we theoretically have control over look and feel, to an extent at least. We'd have to test things out to see where the limitations are, but it's easy enough for us to provide feedback to the CDS team once we've established what will work and what won't for styling purposes.