Sorting table by date sorts alphabetically instead of by time

GCTC-NTGC / gc-digital-talent

GC Digital Talent is the new recruitment platform for digital and tech jobs in the Government of Canada. // Talents numériques du GC est la nouvelle plateforme de recrutement pour les emplois numériques et technologiques au gouvernement du Canada.

https://talent.canada.ca

GNU Affero General Public License v3.0

22 stars 8 forks source link

Sorting table by date sorts alphabetically instead of by time #4774

Closed tristan-orourke closed 1 year ago

tristan-orourke commented 1 year ago

The All Requests and Latest Requests tables include a Date Reveived column. When sorting by the column, it sorts the rows alphabetically based on the display string (eg August, November, October, September) instead of based on the underlying string.

Acceptance Criteria

[ ] Requests tables sort rows by date (not date string) after clicking the Date Received column.

vd1992 commented 1 year ago

the default sort for both is chronological, latest first, so one click on it should do nothing while two clicks flips it 🤔

tristan-orourke commented 1 year ago

Can be fixed by separating a date value into Accessor and Cell https://react-table-v7.tanstack.com/docs/api/useTable#column-options