GCTC-NTGC / gc-digital-talent

GC Digital Talent is the new recruitment platform for digital and tech jobs in the Government of Canada. // Talents numériques du GC est la nouvelle plateforme de recrutement pour les emplois numériques et technologiques au gouvernement du Canada.
https://talent.canada.ca
GNU Affero General Public License v3.0
22 stars 9 forks source link

✨ Add personality to context #7002

Open petertgiles opened 1 year ago

petertgiles commented 1 year ago
          The code looks great! I like the use of `personality`. Feels like something we might want to expand on and put into a context.

Originally posted by @tristan-orourke in https://github.com/GCTC-NTGC/gc-digital-talent/pull/6999#pullrequestreview-1484484652

✨ Feature

PR #6999 added the idea of an app personality that changes the theme, copy, navbar, and home link. In that PR it was implemented by a simple URL query param that was checked for on a few pages. It would probably be better to add this to a context to make this easier and more consistent to expand as necessary.

If the personality is changed to IAP before navigation it could reduce the flicker of theme changes during navigation as well.

🕵️ Details

Add any additional details that could assist with the development of the new feature.

:question: Questions

🎨 Design File

Include a link to the design file (if it exists).

📸 Screenshot

Add a screenshot of the new feature (if possible).

🙋‍♀️ Proposed Implementation

(optional) Do you have a proposed implementation?

🌎 Localization

(optional) Provide any new copy along with translations available.

✅ Acceptance Criteria

petertgiles commented 1 year ago

Not totally clear how to answer these questions and what it would be used for. Icebox for now.