GCTC-NTGC / gc-digital-talent

GC Digital Talent is the new recruitment platform for digital and tech jobs in the Government of Canada. // Talents numรฉriques du GC est la nouvelle plateforme de recrutement pour les emplois numรฉriques et technologiques au gouvernement du Canada.
https://talent.canada.ca
GNU Affero General Public License v3.0
22 stars 9 forks source link

๐Ÿ› IAP referred to as "IT Indigenous Apprenticeship Program" #7113

Closed mnigh closed 1 year ago

mnigh commented 1 year ago

๐Ÿ› Bug

IAP should always be "IT Apprenticeship Program for Indigenous Peoples" NOT "Indigenous Apprenticeship Program"

Source: https://github.com/GCTC-NTGC/gc-digital-talent/issues/6593.

๐Ÿ“‹ Steps to Reproduce

  1. Navigate to /en/login-info?from=/en/indigenous-it-apprentice&personality=iap
  2. Observe IT Indigenous Apprenticeship Program text
  3. Navigate to /en/register-info?from=/en/indigenous-it-apprentice&personality=iap
  4. Observe IT Indigenous Apprenticeship Program text

๐Ÿ“ธ Screenshots

Screen Shot 2023-06-27 at 16 08 54 Screen Shot 2023-06-27 at 16 17 19 Screen Shot 2023-06-27 at 16 17 44

๐Ÿ™‹โ€โ™€๏ธ Proposed Solution

Replace instance of "IT Indigenous Apprenticeship Program" with "IT Apprenticeship Program for Indigenous Peoples". Make sure French equivalent is appropriately translated.

โœ… Acceptance Criteria

A set of assumptions which, when tested, verify that the bug was addressed.

petertgiles commented 1 year ago

An eslint rule to prevent it from happening again.

"no-restricted-syntax": [
      "error",
      {
        selector: "Literal[value=/Indigenous Apprenticeship Program/i]",
        message:
          "The name of the program is IT Apprenticeship Program for Indigenous Peoples.",
      },
    ],
BrookeCameron commented 1 year ago

You are correct @mnigh ! The changes have been made to the Figma file, thanks for catching this.