search

GCTC-NTGC / gc-digital-talent

GC Digital Talent is the new recruitment platform for digital and tech jobs in the Government of Canada. // Talents numériques du GC est la nouvelle plateforme de recrutement pour les emplois numériques et technologiques au gouvernement du Canada.
https://talent.canada.ca
GNU Affero General Public License v3.0
21 stars 8 forks source link

🐛 Some images missing gradients #8480

Open vd1992 opened 10 months ago

vd1992 commented 10 months ago

🐛 Bug

Spinning off from observations in #8405 Some images are missing a gradient.

🕵️ Details

Reference

https://github.com/GCTC-NTGC/gc-digital-talent/pull/8405#issuecomment-1806432561

📸 Screenshot

Example image lacking gradient up top.

282178257-3907e42a-b1a7-491e-9855-0b794754fab2

🙋‍♀️ Proposed Solution

Replace images lacking the desired gradient with images possessing gradients.

✅ Acceptance Criteria

esizer commented 10 months ago

So, I noticed this a while ago and forgot to make a ticket, but it would probably be better to create fixed size images for our heros that have no gradient. We can then create the fade using css in the Hero component.

Relying on gradients being baked into images can be a little tricky and then if we ever want to adjust the gradient, it is much more time consuming to re-export all the images.

I'd love to hear @substrae thoughts, but my preference is to usually do image fades/gradients with css rather than baking them into images.

Also, we could avoid odd things like this 😅

Screenshot 2023-11-15 090648

JoshBeveridge commented 10 months ago

@esizer

I'm in the same boat - I'd rather this be CSS as well. The only caveat is that Brooke might be doing custom gradient variation depending on the subjects in the photo, though I'd be surprised if this were the case.

gobyrne commented 9 months ago

Well, Brooke won't be addressing this, so CSS is the way to go :)

gobyrne commented 9 months ago

Removing blocked-design tag. But let us know if it still needs more from us.

esizer commented 7 months ago

Do we know if this was solved with https://github.com/GCTC-NTGC/gc-digital-talent/issues/9286 ?

JoshBeveridge commented 7 months ago

@esizer It wasn't, unfortunately. I don't have access to all of the original stock photos, so I had to update the new ones to match for now.

gobyrne commented 5 months ago

Waiting on Brooke for this one