search

GCTC-NTGC / gc-digital-talent

GC Digital Talent is the new recruitment platform for digital and tech jobs in the Government of Canada. // Talents numériques du GC est la nouvelle plateforme de recrutement pour les emplois numériques et technologiques au gouvernement du Canada.
https://talent.canada.ca
GNU Affero General Public License v3.0
21 stars 8 forks source link

♻️ Remove deprecated `hasDiploma` field #8661

Open vd1992 opened 9 months ago

vd1992 commented 9 months ago

♻️ Debt/Refactor

The hasDiploma field has been marked as deprecated for sometime and should be removed.

🕵️ Details

The field exists and is referenced in various places, some places where it explicitly is set to do nothing like in filtering. It ought to be removed

🙋‍♀️ Proposed Solution

Remove it

✅ Acceptance Criteria

brindasasi commented 9 months ago

I just see that the filter exists in Pool Candidates table filter in UAT. But it doesn't filter anything based on its selected value. image (27)

vd1992 commented 9 months ago

Yep, it is present in multiple places but disconnected from API making it a filter that does nothing

image

petertgiles commented 9 months ago

This issue got tricky because of the larger question about how education is handled. https://github.com/GCTC-NTGC/gc-digital-talent/issues/8821