GOFIRST-Robotics / Lunabotics

The official NASA Lunabotics GitHub repository for University of Minnesota Robotics.
https://studentrobotics.umn.edu/
12 stars 0 forks source link

Make all motor set commands follow proper ros behavior #257

Open jmblixt3 opened 2 months ago

jmblixt3 commented 2 months ago

Currently the MotorCommandSet service immediately returns instead of blocking for command to be completed. This is problematic because for setting position it will take an unknown amount of time to complete. So by correctly returning a future and calls to spin_until_future_complete would solve this issues. The current work around is a seperate watchdog topic which is a bit overcomplicated.