GOFIRST-Robotics / Lunabotics

The official NASA Lunabotics GitHub repository for University of Minnesota Robotics.
https://studentrobotics.umn.edu/
12 stars 0 forks source link

GitHub Actions Workflow Improvements #263

Open Isopod00 opened 1 month ago

Isopod00 commented 1 month ago

Suggested GitHub Actions Workflow Improvements:

jmblixt3 commented 1 month ago
  1. You can c++ linting just match the ros standard
  2. For bash linting use shellcheck
  3. in order to run unit tests you need to colcon build first
  4. colcon test is the right way to do this, ros repos normally use jenkins so some work will need to be done to get this to work but overall should be relatively easy
jmblixt3 commented 1 month ago

Also instead of just failing as an action make it fix the issues with a new commit for lint errors