GOFIRST-Robotics / Lunabotics

The official NASA Lunabotics GitHub repository for University of Minnesota Robotics.
https://studentrobotics.umn.edu/
14 stars 1 forks source link

Simplified Async Autonomous Actions #270

Closed jmblixt3 closed 2 months ago

jmblixt3 commented 2 months ago

This PR is mostly working but canceling seems to be weird, maybe it's a weird interaction between canceling and the async_sleep() method or something. Whenever I cancel an autonomous action it still seems to be running in the background or something and it is possible to get multiple running at once if I start and cancel an action repeatedly, because canceling does not seem to be fully canceling.

This appears to be fixed now for all actions, give it another try! I think the difference we had was I hadn't tried to cancel during sleep, only skimmer movement