search

GSA / code-gov-api

API powering the code.gov source code harvester
http://code.gov
Other
53 stars 28 forks source link

Revert to original response #309

Closed froi closed 5 years ago

froi commented 5 years ago

A similar PR may already be submitted! Please search among the Pull request before creating one.

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request:

For more information, see the CONTRIBUTING guide.

Summary

The response for the languages endpoint was changed in a counterproductive way. This change aims to revert the endpoint to have the original response

This PR fixes/implements the following bugs/features

Explain the motivation for making this change. What existing problem does the pull request solve?

The response for the languages endpoint was changed in a counterproductive way. This change aims to revert the endpoint to have the original response

Test plan (required)

froi commented 5 years ago

Not to be merges before the clean up PR get approved #308

froi commented 5 years ago

@saracope Friendly ping for your attention 😄

saracope commented 5 years ago

@froi Does the CI always fail on these? Is that something I need to ask BJ to look at?

froi commented 5 years ago

CircleCI

Integration tests will sometimes fail because of timeouts or execution issues. On occasions running just the integration tests will solve it.

Code Climate

These are the eternal struggle on this project. Depending on the code added I would sometimes approve them in Code Climate and assume the technical debt. The real symptom is that tests need to be improved.

Recommendation

I would totally have BJ look at them. At the very least it will help him familiarize himself with the code faster.

saracope commented 5 years ago

Pinging @bjbhatt for review.

froi commented 5 years ago

Hello fine peeps. A friendly ping about this. I'd like to get it out of my PRs.