search

GSA / code-gov-api

API powering the code.gov source code harvester
http://code.gov
Other
53 stars 28 forks source link

X-RateLimit-Reset #332

Open Nosferican opened 5 years ago

Nosferican commented 5 years ago

Is your feature request related to a problem? Please describe. The API offers X-RATE-Limit and X-RATE-Remaining, but no X-Rate-resetAt.

Describe the solution you'd like The headers should include a X-Rate-ResetAt.

Describe alternatives you've considered The value could be a unix timestamp or a zoned date time.

Additional context X-Rate-resetAt is very valuable in case someone is reaching the limit, but it also fully specifies the rate limit per period. Currently, the information on the rate limit is 1,000 / unknown time period.

froi commented 5 years ago

Hey peeps! Long time no see code.gov.

@Nosferican I think that's not a Code.gov thing. The rate limit is handled by https://api.data.gov/ as well as the api key. The response headers are added by them.

At least it was like that when I was around 😄

Nosferican commented 5 years ago

Thanks for the information. I found https://github.com/NREL/api-umbrella/issues/377 (created on 2017-07-30) which had that request. On this end, maybe we should document that it uses the api.data.gov and a link to their docs.

ioggstream commented 4 years ago

FYI there's an ongoing work for standardizing ratelimit headers under HTTP, that is supported by various implementors and governments. See: