WIP: automated package and publish of MAP

GSTT-CSC / TotalSegmentator-AIDE

TotalSegmentator packaged as an AIDE Application, based on the MONAI Application Package (MAP) standard.

Other

24 stars 5 forks source link

WIP: automated package and publish of MAP #26

Open tomaroberts opened 1 year ago

tomaroberts commented 1 year ago

WIP: GitHub Action to automatically build and publish the MAP on release. See #24.

Currently, build is almost working.

TODO:

figure out why map-init build failed (https://github.com/GSTT-CSC/TotalSegmentator-AIDE/actions/runs/4949810507)
- nb: GH Action says succeeded, but map-init stage failed because failed to get one of the layers. Action continued anyway because currently the 3rd-party software step is independent of the previous step.
- add in check after MAP build complete
- add in check to verify that built MAP is sufficient for release

tomaroberts commented 1 year ago

Tom, reminder to self, GHA currently failing to find map/init:temp when attempting to build map/final:temp. Also not sure the map/init:temp build is fully completing.

tomaroberts commented 1 year ago

With latest commit, adjusted publish_map.yml to include all MAP build commands within a single step (to test whether separating commands across steps was the problem), however this did not solve the issue, as evidenced by screenshot above.

In all cases, the MAP build seems to fails after Step 19, although it doesn't produce an Exception. This means the GitHub Action continues, thinking everything is fine. Hence, the docker images output displays Image ID 57f799 as <none> and the Size is 15.5GB whereas it should be >18GB.

tomaroberts commented 1 year ago

Related aside...

Tried to see if I could build MAP by... 1) building a Docker image containing third-party software with nvcr.io/nvidia/pytorch:22.08-py3 as base image, since this is default MAP base image 2) then building on top of this using monai-deploy package ... --base <base_image> however this failed:

monai-deploy package ... complains that my tagged image is not a "Cuda or Pytorch image from ..."

MONAI Deploy asks for

tomaroberts commented 1 year ago

Still can't get this working...

Seems to be a problem with Step 19 in the monai-deploy package app command, which relates to COPYing the requirements.txt into the MAP.

See here for updates: https://github.com/Project-MONAI/monai-deploy-app-sdk/issues/431#issuecomment-1625426592