Multi-draw indirect crashes without lwjgl3ify

wahfl2 commented 6 months ago

Your GTNH Discord Username

beljihnwahfl

Mod Version

1.0.0-alpha34

Java Version

Java 8

Graphics Card Vendor

Intel iGPU

Bug Report

Enabling multi-draw indirect and entering any world/server causes a crash without lwjgl3ify installed. Seemingly, this would happen regardless of setup.

https://mclo.gs/5CGAaD2

I tested the same instance + world after installing lwjgl3ify and it worked without crashing.

Mod List or GTNH Pack Version

Only Angelica + deps

Final Checklist

[X] I have searched the issues and haven't found a similar issue.
[X] I have read the known incompatibilities and this is not related to one of those.
[X] I am running an officially released version. (Or, if I've compiled it myself I plan to fix the issue)
[X] This issue is not related to a feature that is disabed by default - Shaders, MCPF, etc. [They'll be enabled when they're ready for testing]

mitchej123 commented 6 months ago

~~What OS?~~ Looks like win10 from the log

Seems like an Intel specific issue this far.... I've run multidraw on linux, with nvidia, and lwjgl2 without issue. (I'll test it again tonight to verify it's not a regression).

mitchej123 commented 6 months ago

It seems to currently only be reproducible on intel drivers running on windows, while using lwjgl2. Apparently lwjgl3 disabled some checks for speed.

The two options seem to be: 1) Disabling the check via -Dorg.lwjgl.util.NoChecks=true 2) Using Oneshot instead of Multidraw

AnrDaemon commented 6 months ago

-Dorg.lwjgl.util.NoChecks=true

Confirmed to be working with my setup. No more crashes with multidraw option enabled.

justaguywhowantsminecraftmods commented 6 months ago

It seems to currently only be reproducible on intel drivers running on windows, while using lwjgl2. Apparently lwjgl3 disabled some checks for speed.

The two options seem to be:

Disabling the check via -Dorg.lwjgl.util.NoChecks=true

Using Oneshot instead of Multidraw

where do I find Dorg.lwjgl.util.NoChecks=true?

quentin452 commented 6 months ago

-Dorg.lwjgl.util.NoChecks=true its probably a jvm arguments that you need to put

AnrDaemon commented 6 months ago

Yes, it is a JVM argument.

GTNewHorizons / Angelica