Vanilla chests flicker when Logistics Pipes are in view and GL state caching is enabled

szuend commented 4 months ago

Your GTNH Discord Username

nimodota

Mod Version

1.0.0-alpha50

Java Version

Java 21

Graphics Card Vendor

NVidia

Bug Report

This looks very similar to GTNewHorizons/GT-New-Horizons-Modpack#16233 but filed with more concrete repro steps.

Create a new standard flat world.
Place some vanilla chests
Place any "Logistics Pipes" Pipe, e.g. an "Unrouted Transport Pipe"

Observe that the chests render with wrong brightness.

broken working

Observe that every time you move the pipe out of the viewport the chests switch back to bright. As soon as the pipe comes back into view the chests switch back to darker.

The chest's brightness is also fixed by disabling the GL state caching.

Mod List or GTNH Pack Version

Logistics Pipe Version: 1.2.1-GTNH

Running from a Logistics Pipes checkout via gradlew :runClient21 + manually added angelica mod in the run directory.

Final Checklist

[X] I have searched the issues and haven't found a similar issue.
[X] I have read the known incompatibilities and this is not related to one of those.
[X] I am running an officially released version. (Or, if I've compiled it myself I plan to fix the issue)
[X] This issue is not related to a feature that is disabed by default - Shaders, MCPF, etc. [They'll be enabled when they're ready for testing]

szuend commented 4 months ago

To capture some of the discord discussion: The current suspicion is that the LP pipe TESR sets some state in the display list that Angelica doesn't properly replay.

Note that LogisticsNewRenderPipe does not implement the TESR interface, but the actual TESR delegates to the LogisticsNewRenderPipe.

Cleptomania commented 2 days ago

This has been fixed in Logistics Pipes

GTNewHorizons / Angelica