GTNewHorizons / Angelica

OptiFine replacement for 1.7.10
Other
248 stars 42 forks source link

Fog inconsistency between server and single player #531

Closed Brunnosh closed 3 months ago

Brunnosh commented 3 months ago

Your GTNH Discord Username

Brunosh

Mod Version

1.0.0-alpha52

Java Version

Java 17

Graphics Card Vendor

NVidia

Bug Report

No crashes or anything, just fog being inconsistent. on single player worlds it works fine, changing the render distance slider actually changes something. now on servers, anything past 12 view distance on the server.properties file does not change anything, tested it by going 1 below (11), and it was slightly closer, and 1 above (13), being exactly as 12 render distance. for testing purposes i deleted angelica and installed optifine, disabling fog on it i could see to the full 20 chunks even on server

Mod List or GTNH Pack Version

GTNH 2.6.1 no additional mods

Final Checklist

OvermindDL1 commented 3 months ago

Did you up the chunk distance in the server configuration to send further than 12? I have mine set to 24 (yes this is pretty extreme) and it works as expected.

Brunnosh commented 3 months ago

Did you up the chunk distance in the server configuration to send further than 12? I have mine set to 24 (yes this is pretty extreme) and it works as expected.

isn't that just increasing view-distance on server.properties? if it is, then yes, i did it. and i really dont think it is a config problem, because with optifine it works as intended

OvermindDL1 commented 3 months ago

On my server I have 24 view-distance and on my client I have 24 view distance and fog seems correct, far into the distance? I wonder what else differs...

Brunnosh commented 3 months ago

On my server I have 24 view-distance and on my client I have 24 view distance and fog seems correct, far into the distance? I wonder what else differs...

what version of angelica are you using?

OvermindDL1 commented 3 months ago

Mine is: angelica-1.0.0-alpha51a-beta.34+8c12fe9acd.jar

Brunnosh commented 3 months ago

Mine is: angelica-1.0.0-alpha51a-beta.34+8c12fe9acd.jar

no luck, tried alpha51 and alpha50 but same thing, its so strange, it has to be something with my client since optifine works normally

OvermindDL1 commented 3 months ago

What modpack are you running so we can try to duplicate? Link or upload or so?

Brunnosh commented 3 months ago

What modpack are you running so we can try to duplicate? Link or upload or so?

literally the packaged GTNH server and client with java 17, nothing more, nothing less

OvermindDL1 commented 3 months ago

Huh, that's exactly what I'm running, GTNH 2.6.1 (with my slightly edited angelica but nothing about fog), although I'm running java21, I can't see how that would make a difference either though...

I wonder if this is yet another of those nvidia'isms that might need to be worked around...

I'll try to actually test mine in depth tonight with the latest released angelica though after work if someone could ping me in like 7 hours from the time of this message or so?

Valeqs commented 3 months ago

Huh, that's exactly what I'm running, GTNH 2.6.1 (with my slightly edited angelica but nothing about fog), although I'm running java21, I can't see how that would make a difference either though...

I wonder if this is yet another of those nvidia'isms that might need to be worked around...

I'll try to actually test mine in depth tonight with the latest released angelica though after work if someone could ping me in like 7 hours from the time of this message or so?

ping

Valeqs commented 3 months ago

Isn't there a way to completly turn off the fog?

Huh, that's exactly what I'm running, GTNH 2.6.1 (with my slightly edited angelica but nothing about fog), although I'm running java21, I can't see how that would make a difference either though...

I wonder if this is yet another of those nvidia'isms that might need to be worked around...

I'll try to actually test mine in depth tonight with the latest released angelica though after work if someone could ping me in like 7 hours from the time of this message or so?

Isn't there an option to remove the fog completly?

OvermindDL1 commented 3 months ago

Huh, that's exactly what I'm running, GTNH 2.6.1 (with my slightly edited angelica but nothing about fog), although I'm running java21, I can't see how that would make a difference either though... I wonder if this is yet another of those nvidia'isms that might need to be worked around... I'll try to actually test mine in depth tonight with the latest released angelica though after work if someone could ping me in like 7 hours from the time of this message or so?

ping

Oh bugger, I took the screenshots but didn't have a browser available at the moment to upload them, here you go, this is how it looks to me at 11, 12, 13, and like 22 I think it was.

2024-06-18_22 03 48 2024-06-18_22 04 02 2024-06-18_22 04 14 2024-06-18_22 04 29

Valeqs commented 3 months ago

Huh, that's exactly what I'm running, GTNH 2.6.1 (with my slightly edited angelica but nothing about fog), although I'm running java21, I can't see how that would make a difference either though... I wonder if this is yet another of those nvidia'isms that might need to be worked around... I'll try to actually test mine in depth tonight with the latest released angelica though after work if someone could ping me in like 7 hours from the time of this message or so?

ping

Oh bugger, I took the screenshots but didn't have a browser available at the moment to upload them, here you go, this is how it looks to me at 11, 12, 13, and like 22 I think it was.

2024-06-18_22 03 48 2024-06-18_22 04 02 2024-06-18_22 04 14 2024-06-18_22 04 29

Thats my fog at 24 2024-06-28_14 46 30

Caedis commented 3 months ago

What did you edit in Angelica, @OvermindDL1? Is it based on alpha or beta?

Valeqs commented 3 months ago

What did you edit in Angelica, @OvermindDL1? Is it based on alpha or beta?

I just downloaded it from the mirahaze website the java 17 version 2.6.1. It comes with alpha 50. I didnt change anything in the settings besides 24 render distance fov 75 and brightness 100

Caedis commented 3 months ago

@Valeqs can you try alpha52?

Valeqs commented 3 months ago

@Valeqs can you try alpha52?

Tried 50 51 52 49 41 same thing, i just wish there is an option to remove that fog completly

Caedis commented 3 months ago

What happens if you remove Angelica completely?

Valeqs commented 3 months ago

What happens if you remove Angelica completely?

i replaced angelica with optifine once and the fog was gone. But the problem is you wont see polution and my fps went down to 90 instead of 144.

Caedis commented 3 months ago

I am talking without Angelica and Optifine

Valeqs commented 3 months ago

without angelica it crashes.

https://mclo.gs/iUtCNPj

I am talking without Angelica and Optifine

Caedis commented 3 months ago

Can you post your fml client latest file?

Valeqs commented 3 months ago

fml-client-latest.log

Can you post your fml client latest file?

Caedis commented 3 months ago

Can you disable BetterCrashes? Seems like that mod is hiding the true error

Valeqs commented 3 months ago

fml-client-latest.log

Can you disable BetterCrashes? Seems like that mod is hiding the true error

Caedis commented 3 months ago

I think something is wrong with your instance. I just downloaded 2.6.1 and disabled Angelica and loaded into the pack without issue.

Can you try a fresh download of 2.6.1 (https://downloads.gtnewhorizons.com/Multi_mc_downloads/GT_New_Horizons_2.6.1_Java_17-21.zip)?

Valeqs commented 3 months ago

I think something is wrong with your instance. I just downloaded 2.6.1 and disabled Angelica and loaded into the pack without issue.

Can you try a fresh download of 2.6.1 (https://downloads.gtnewhorizons.com/Multi_mc_downloads/GT_New_Horizons_2.6.1_Java_17-21.zip)?

I downloaded a new Profile. I didnt add anything and removed Angelica, It loaded. It may have something to do with replaymod or a newer version of twilight forest that I added to my mods folder.

I tried loading my new Instance with and without Angelica but there is no difference.

No Angelica 16 chunks (max is 16) 2024-06-29_13 12 05

With Angelica 16 Chunks (max is 32) 2024-06-29_13 16 32

With Angelica 24 Chunks (max is 32) 2024-06-29_13 16 57 /tim

Caedis commented 3 months ago

Least that solves that issue Try adding the new mods 1 at a time.

Also, you did stop the server, change server.properties, then start the server, right?

Valeqs commented 3 months ago

https://imgur.com/GN2DKQ2

So now I created a new world in my old instance and as soon as a change gamemodes the render distance changes so it worked but it is only in creative possible, can I also get this in survival?

Least that solves that issue Try adding the new mods 1 at a time.

Also, you did stop the server, change server.properties, then start the server, right?

Least that solves that issue Try adding the new mods 1 at a time.

Also, you did stop the server, change server.properties, then start the server, right?

Valeqs commented 3 months ago

Least that solves that issue Try adding the new mods 1 at a time.

Also, you did stop the server, change server.properties, then start the server, right?

I forgot to change it to 16 i didnt knew it only supports 16. Server is set to 24

Caedis commented 3 months ago

Oh, OH.

Try this angelica-1.0.0-alpha42-beta.47+657645d883.jar.zip

Ignore the alpha42, its built off the beta branch. Unzip it btw

Valeqs commented 3 months ago

Oh, OH. > > Try this angelica-1.0.0-alpha42-beta.47+657645d883.jar.zip > > Ignore the alpha42, its built from the beta branch. Unpacking it btw

no difference unfortunately. I replaced the 50alpha with this jar and still the same, only when im in creative in singeplayer it works.

Caedis commented 3 months ago

Cool, im able to recreate it. Lemme see if i can find the cause

Caedis commented 3 months ago

Looks like its another mod that is causing it. Can't recreate it in the angelica dev env

Caedis commented 3 months ago

Found the issue. You can enable everything again.

Edit the config file "GregTech/Client.cfg" and change B:RenderPollutionFog_true=true to B:RenderPollutionFog_true=false

Valeqs commented 3 months ago

It worked thx for your help

Found the issue. You can enable everything again.

Edit the config file "GregTech/Client.cfg" and change B:RenderPollutionFog_true=true to B:RenderPollutionFog_true=false

OvermindDL1 commented 3 months ago

What did you edit in Angelica, @OvermindDL1? Is it based on alpha or beta?

No edits in this one in the pictures, that was normal alpha52

OvermindDL1 commented 3 months ago

Found the issue. You can enable everything again.

Edit the config file "GregTech/Client.cfg" and change B:RenderPollutionFog_true=true to B:RenderPollutionFog_true=false

So was mine rendering correctly because I have a few hundred thousand pollution in my world?

ah-OOG-ah commented 3 months ago

Found the issue. You can enable everything again. Edit the config file "GregTech/Client.cfg" and change B:RenderPollutionFog_true=true to B:RenderPollutionFog_true=false

So was mine rendering correctly because I have a few hundred thousand pollution in my world?

No, it's a bug. The pollution renderer was incorrectly capping render distance even when no pollution was present in the chunk - iirc Caedis made a PR to fix that

OvermindDL1 commented 3 months ago

Found the issue. You can enable everything again. Edit the config file "GregTech/Client.cfg" and change B:RenderPollutionFog_true=true to B:RenderPollutionFog_true=false

So was mine rendering correctly because I have a few hundred thousand pollution in my world?

No, it's a bug. The pollution renderer was incorrectly capping render distance even when no pollution was present in the chunk - iirc Caedis made a PR to fix that

That's what I'm asking about, why was mine rendering fine then? Standard GTNH pack with alpha 52 Angelica.

Oninaig commented 1 month ago

Is this still an issue in angelica 1.0.0-beta4 on GTNH 2.6.1?