GaijinEntertainment / DagorEngine

Dagor Engine and Tools source code from Gaijin Games KFT
Other
2.15k stars 268 forks source link

Linux port of shader compiler (dsc-spirv). #14

Closed seanballais closed 7 months ago

seanballais commented 9 months ago

NOTE: This PR is not yet ready for merging. I only created this PR to allow myself and others to track my porting efforts of the shader compiler as well as provide Gaijin and other interested parties avenues for feedback. Consider all commits as unstable.

Task:


seanballais commented 9 months ago

Thanks for the valuable feedback, @romasandu-gaijin! I really appreciate it. I'll get back to those this week once I am able to.

NicSavichev commented 9 months ago

NOTE: This PR is not yet ready for merging. I only created this PR to allow myself and others to track my porting efforts of

I've updated code in our repo to alternatively compile dsc2-spriv-dev (though some changes may be the same as you have done), I expect working compiler included in next sync to DagorEngine. I will reuse parts of your scripts that download and build DXC (needed for both linux64 and macOS), thanks for good job!

seanballais commented 9 months ago

NOTE: This PR is not yet ready for merging. I only created this PR to allow myself and others to track my porting efforts of

I've updated code in our repo to alternatively compile dsc2-spriv-dev (though some changes may be the same as you have done), I expect working compiler included in next sync to DagorEngine. I will reuse parts of your scripts that download and build DXC (needed for both linux64 and macOS), thanks for good job!

Hey, @NicSavichev! Sure. Thanks. I'll check out your changes too once I am able to, so that we can confirm that the code works in different platforms and to uncover any compilation bugs.

Had to commit to other matters the past two weeks so I wasn't able to work on this for a while.

Should we close this PR since you're working on dsc2-spirv-dev?

NicSavichev commented 9 months ago

Should we close this PR since you're working on dsc2-spirv-dev?

Let's close it after DagorEngine repo updated and we ensure that shader compiler is compilable and usable under linux

NicSavichev commented 7 months ago

I've finally published release where shader compiler (along with dabuild and other utilities) are buildable for linux (and macOS)

seanballais commented 7 months ago

Hey, @NicSavichev! That's great news. I'll try compiling those utilities in my Linux machine if I have time to help make sure they're running smoothly. Might submit some fixes if there are any issues (especially since I'm running Pop!_OS). In any case, great job! 🥳