search

GaijinEntertainment / DagorEngine

Dagor Engine and Tools source code from Gaijin Games KFT
Other
2.14k stars 267 forks source link

cleanup usage of __super with base declaration #21

Closed pollend closed 6 months ago

pollend commented 7 months ago

I was considering trying to get a couple of these utilities working on linux. I don't think the __super extension is available for g++ so I think its a good early step to resolve these compiler errors. I prefer the more explicit calls, it's a lot easier to understand without trying to figure out how this squares with multi inheritance.

https://gcc.gnu.org/legacy-ml/gcc/2004-08/msg01276.html

NicSavichev commented 7 months ago

I was considering trying to get a couple of these utilities working on linux. I don't think the __super extension is available for g++ so I think its a good early step to resolve these compiler errors. I prefer the more explicit calls, it's a lot easier to understand without trying to figure out how this squares with multi inheritance.

I'm doing the same at the moment (expect shaderCompiler and dabuild to be buildabale and usable under linux/macOS). But daEditorX and AssetViewer are not expected to be ported, they are too heavy windows-related.

pollend commented 7 months ago

I was considering trying to get a couple of these utilities working on linux. I don't think the __super extension is available for g++ so I think its a good early step to resolve these compiler errors. I prefer the more explicit calls, it's a lot easier to understand without trying to figure out how this squares with multi inheritance.

I'm doing the same at the moment (expect shaderCompiler and dabuild to be buildabale and usable under linux/macOS). But daEditorX and AssetViewer are not expected to be ported, they are too heavy windows-related.

Umm I see, anything in particular. I don't mind addressing some minor upkeep to just get familiar.

NicSavichev commented 6 months ago

Change is not relevant anymore (is refactored other way)