search

Galooshi / import-js

A tool to simplify importing JS modules
MIT License
524 stars 70 forks source link

Upgrade sqlite3 to v5 #588

Closed mikabytes closed 7 months ago

mikabytes commented 7 months ago

The old v4 sqlite3 requires node-gyp to build from source, which doesn't compile on a modern machine. I'm not sure as to exactly why, just that the general recommendation is to upgrade to v5 which uses Node API bindings.

This PR does exactly that. I haven't tested this extensively, just used it as usual in my projects, and it seems to be fine.

Additional testing would be appreciated.

It's been a few years since import-js made a release. Since then the package lockfile format has changed and is automatically updated. This resulted in a huge changeset for this PR. I promise I haven't changed anything else than sqlite3 though :-)

mikabytes commented 7 months ago

Ah yikes.... I mistook git fetch for git fetch upstream and based this branch on an old commit. Master here already uses sqlite3 v5.

Closing this.