search

Galooshi / import-js

A tool to simplify importing JS modules
MIT License
524 stars 70 forks source link

Move to Prettier, abandon ESlint #594

Closed mikabytes closed 7 months ago

mikabytes commented 7 months ago

Recently I made a pull request and hit several speedbumps due to convention issues. While this is perhaps not overly important, it is a bit of an annoyance.

Me and my colleagues have used Prettier for the past several years and we have the feeling of "never, ever, going back". It fixes conventions automatically and ensures conformity. For me, it leads to developer bliss, whereas ESlint and such hinders flow.

Perhaps we could include it in this project also?

mikabytes commented 7 months ago

As a personal preference, I would recommend using Prettier defaults all except semi: false. Prettier makes it obvious wherever ASI fails, which is a rare occurance. Also, there's the TypeScript aspect

trotzig commented 7 months ago

Sounds good! I also prefer to use semicolons, so that would be a good config.

mikabytes commented 7 months ago

Great :)

But maybe I was unclear, I prefer not to use semicolons. I know this is a heated debate in the community with strong opinions in both directions. I'm in camp "Don't add something useless if you don't have to". But I respect that others disagree, and seeing as the established convention in this project is to use them, I can endure keeping them ;)

trotzig commented 7 months ago

Okay! You pick, as long as the config is there it’s going to be consistent anyway. 🙂👍