Closed JohnsonMao closed 9 months ago
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
✅ Knip Scan Result for https://github.com/Game-as-a-Service/Game-Lobby-Web/pull/357/commits/472476da10d0cabd8842bbcd898fecd3ae57bb14
🤖 Lighthouse Scan Result for https://github.com/Game-as-a-Service/Game-Lobby-Web/pull/357/commits/472476da10d0cabd8842bbcd898fecd3ae57bb14
Hello @JohnsonMao ,觀察 storyBook 的呈現後(如下圖),似乎尚有兩個 svg 檔案可以設定其預設的 stroke,分別是 navArrowLeft 及 sent,想詢問是否須一併調整呢?
PS. 四個第三方登入的 Icon,似乎得用 fill 屬性來進行設定,故先忽略。
感謝你的回覆~ 我在另一個分支 (#356 ) 已經有先修改那兩個 icon 了,所以這兩個沒特別修改避免合併衝突
Why need this change? / Root cause:
Changes made:
Test Scope / Change impact:
-
Issue
-