Game-as-a-Service / Game-Lobby-Web

The frontend of the Game as a Service lobby.
https://lobby.gaas.waterballsa.tw/
Apache License 2.0
25 stars 7 forks source link

refactor icon stroke and storybook background #357

Closed JohnsonMao closed 9 months ago

JohnsonMao commented 9 months ago

Why need this change? / Root cause:

Changes made:

Test Scope / Change impact:

-

Issue

-

sonarcloud[bot] commented 9 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

GaaSBot commented 9 months ago

Knip Scan Result for https://github.com/Game-as-a-Service/Game-Lobby-Web/pull/357/commits/472476da10d0cabd8842bbcd898fecd3ae57bb14

Unused files (9) | Unused files (9) | |------------------| | .bundlewatch.config.js | | components/shared/Chat/ChatContent.tsx | | components/shared/Chat/ChatMessage.tsx | | components/shared/Chat/index.tsx | | configs/i18nConfigs.ts | | lighthouserc.js | | reset.d.ts | | scripts/knipScanReporter.js | | scripts/lhciScanReporter.js |
Unused dependencies (2) | Unused dependencies (2) | |-------------------------| | **@svgr/webpack** package.json | | **sharp** package.json |
Unused devDependencies (5) | Unused devDependencies (5) | |----------------------------| | **@actions/github** package.json | | **@octokit/core** package.json | | **@storybook/blocks** package.json | | **@storybook/testing-library** package.json | | **@total-typescript/ts-reset** package.json |
Configuration issues (1) | Configuration issues (1) | |--------------------------| | **Unused** item in ignoreDependencies: @next/bundle-analyzer |
GaaSBot commented 9 months ago

🤖 Lighthouse Scan Result for https://github.com/Game-as-a-Service/Game-Lobby-Web/pull/357/commits/472476da10d0cabd8842bbcd898fecd3ae57bb14

/rooms | Metric | Value | |--------|-------| | Performance | 73 | | Seo | 78 | | Accessibility | 78 | | HTML Report for LHCI Scan | [Report Link](https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1700402686597-97389.report.html) |
/rooms/abc | Metric | Value | |--------|-------| | Performance | 77 | | Seo | 78 | | Accessibility | 64 | | HTML Report for LHCI Scan | [Report Link](https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1700402686888-82441.report.html) |
/login | Metric | Value | |--------|-------| | Performance | 47 | | Seo | 80 | | Accessibility | 94 | | HTML Report for LHCI Scan | [Report Link](https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1700402687133-92443.report.html) |
Yuwen-ctw commented 9 months ago

Hello @JohnsonMao ,觀察 storyBook 的呈現後(如下圖),似乎尚有兩個 svg 檔案可以設定其預設的 stroke,分別是 navArrowLeft 及 sent,想詢問是否須一併調整呢? image

PS. 四個第三方登入的 Icon,似乎得用 fill 屬性來進行設定,故先忽略。

JohnsonMao commented 9 months ago
Reply to @Yuwen-ctw > Hello @JohnsonMao ,觀察 storyBook 的呈現後(如下圖),似乎尚有兩個 svg 檔案可以設定其預設的 stroke,分別是 navArrowLeft 及 sent,想詢問是否須一併調整呢? ![image](https://user-images.githubusercontent.com/114204927/284116314-3de2d405-adfd-4f4a-99d4-0c963ed49aef.png) > > PS. 四個第三方登入的 Icon,似乎得用 fill 屬性來進行設定,故先忽略。

感謝你的回覆~ 我在另一個分支 (#356 ) 已經有先修改那兩個 icon 了,所以這兩個沒特別修改避免合併衝突