search

Gargron / fileupload

PHP FileUpload library that supports chunked uploads
MIT License
459 stars 87 forks source link

Fix issue #40 and added new fileNameGenerator for slugged file #42

Closed diegocavalletti closed 7 years ago

diegocavalletti commented 7 years ago

Fix to https://github.com/Gargron/fileupload/issues/40 and added a new FileNameGenerator that automatically slugify the file name so that on the server it appears with url friendly name

adelowo commented 7 years ago

The slug generator is great though. That should have been another pull request anyways.

Edit - There aren't tests for the slug generator.. Can you add those too ? You can take a look at how others were implemented (https://github.com/Gargron/fileupload/tree/master/tests/FileUpload/Validator).

diegocavalletti commented 7 years ago

I think it mark the whole file because i have custom indentation in my dev-env, so when it reformatted the code it marked it all as modified, should i just delete the pull request and perform 2 new one? one with just the fix and the other one with the slug generator?

Sorry but it's my first time doing this, i'll just follow your instructions

adelowo commented 7 years ago

@diegocavalletti That would be better. 2 pull requests would be better.