Gargron / fileupload

PHP FileUpload library that supports chunked uploads
MIT License
460 stars 87 forks source link

the call of the processCallbacksFor for completed is in the wrong place #49

Closed Paradinight closed 7 years ago

Paradinight commented 7 years ago

the call of the processCallbacksFor for completed is in the wrong place.

https://github.com/Gargron/fileupload/blob/master/src/FileUpload/FileUpload.php#L349

should be $file = new $file($file_path); $file->completed = $completed; $file->size = $file_size; if($completed === true) { $this->processCallbacksFor('completed', $file); } the first version show the tmp file not the real file

adelowo commented 7 years ago

Whoops, i didn't review properly after i added \SplfileInfo.. Thanks a lot, i have fixed that in https://github.com/Gargron/fileupload/commit/5e34ab9780c2a989fd4b6152b212c136c678e64f plus tag 1.4.3

Paradinight commented 7 years ago

Thank :)

adelowo commented 7 years ago

You welcome 👍