Closed Michionlion closed 4 years ago
Hi @Michionlion, is it this PR that will ultimately make it possible to use the version:
tag correctly? What do we need to fix for this PR so that this tag will start working and then we can more effectively do local testing with a tagged/branched version of GatorGrader?
No, that fix has not been made yet, although this should work for non-branches and new branches; but if a branch is updated, only a fetch is performed, not a pull. That will change in the future when I get a chance to add that!
Hi @Michionlion, when you have time, can you please give me a status update on this PR? I plan to start working on the linting interface and the plugin architecture over the weekend and I'm guessing that it would be useful for me to have a fully working version of the version:
tag so that I can easily try out my implementation in an existing project. Thanks again for your help with this plugin! Any insights and effort that you can provide would be greatly appreciated!
Are we ready for merging here? Does the configuration setup now implemented work for our needs?
I would like at least one independent code review of everything one more time before we merge it, @gkapfham @schultzh @corlettim @alexheinle.
Here is an overview of what got changed by this pull request:
Issues
======
+ Solved 33
- Added 10
Complexity increasing per file
==============================
- src/main/java/org/gatorgradle/display/CommandOutputSummary.java 2
- src/main/java/org/gatorgradle/task/GatorGradleGradeTask.java 8
- src/main/java/org/gatorgradle/task/GatorGradleReportTask.java 1
Complexity decreasing per file
==============================
+ src/main/java/org/gatorgradle/task/GatorGradleTask.java -8
See the complete overview on Codacy
Are we ready for merging here? Does the configuration setup now implemented work for our needs?
Yes @Michionlion since we have decided to use plaintext, the code we have now should work. I have also added some documentation/instruction to the README. After merging this PR, I will test it again in Travis CI.
This PR, while still in development, has all the core features required for sending an HTTP POST request to a specified endpoint whenever
gradle grade
is run. This request has a JSON body as seen below. There are some additional considerations for this PR: the biggest one is how to identify each user, since there may not be a central identification paradigm. We could use the configured Git email (which may be machine based), an IP, a machine hostname, etc. All of these have various drawbacks, and I'd like to open this up for discussion. As well as that, is there any more datapoints we should be collecting?This PR is a feature update that fixes #33.
Developers
@Michionlion @enpuyou