search

GeekyDeaks / discord-destinybot

Discord Destiny Bot
MIT License
8 stars 3 forks source link

Add Mongo Config Options #13

Closed unisys12 closed 7 years ago

unisys12 commented 7 years ago

You have already implemented pretty much what I had suggested, so... I just added the config options to the config_template, making sure to comment them out. If not, they try to use all of them. The user should uncomment the options they need.

GeekyDeaks commented 7 years ago

Hey chap - why did you comment out the options? Since it's a template I think it would be fine to keep them in with the notes you have commented, but wanted to check if you found an issue with that.

unisys12 commented 7 years ago

With options enabled, it tries to use them all. If they are empty, the connection will fail. Think might need to revisit this cause it seems fairly "hacky". If you don want to pull it in right now, that's cool. Been having internet issues today so not able to get thing done. Sorry.

On Sun, Aug 21, 2016, 3:19 PM Scott Deakin notifications@github.com wrote:

Hey chap - why did you comment out the options? Since it's a template I think it would be fine to keep them in with the notes you have commented, but wanted to check if you found an issue with that.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GeekyDeaks/discord-destinybot/pull/13#issuecomment-241279377, or mute the thread https://github.com/notifications/unsubscribe-auth/AB_vg7rq_egxUtAAiSrihA26luEnyx5Nks5qiLLAgaJpZM4JpTXi .