search

GeekyDeaks / discord-destinybot

Discord Destiny Bot
MIT License
8 stars 3 forks source link

Private Channel Errors #2

Closed GeekyDeaks closed 7 years ago

GeekyDeaks commented 7 years ago

Some of the commands rely on information that is only available on a server channel. This should be cleanly dealt with instead of providing a obscure error message.

GeekyDeaks commented 7 years ago

commit b3f64e5 sets a default server, so that when commands are issued via PM, it can fall back to a server and still work. This is fine for 1:1 bot:server setups, which since there is bugger all per-server logic anywhere to be seen, should be fine for now.

This also allows users to decide if verbose commands should be kept private or flood the server channel.

GeekyDeaks commented 7 years ago

Phillip, let me know if this fix addresses your wish to have the bot PM responses. If we need multiple server support then it's not going to work...

unisys12 commented 7 years ago

Will do. Hopefully my internet will be working when I get home from work this afternoon.

On Mon, Aug 22, 2016, 10:24 AM Scott Deakin notifications@github.com wrote:

Phillip, let me know if this fix addresses your wish to have the bot PM responses. If we need multiple server support then it's not going to work...

— You are receiving this because you were assigned.

Reply to this email directly, view it on GitHub https://github.com/GeekyDeaks/discord-destinybot/issues/2#issuecomment-241449325, or mute the thread https://github.com/notifications/unsubscribe-auth/AB_vg3lNc6X7nVBGU1I2eIELTGaMaknBks5qib9EgaJpZM4Jjndj .

GeekyDeaks commented 7 years ago

Added further logic to allow responses to be public /private in commit 2ebda29. By default all messages are private unless the keyword public is at the end of the command. Also by default, all public errors will be deleted after 10 seconds.

To achieve this I abstracted out the send and update messages to a separate module bot/messages.js. The functions in there also take into account the maximum message size and break up the text into smaller messages. This only works if you send an array though, which by default will be joined with \n

unisys12 commented 7 years ago

From what I've played with, it works great. Like the idea of giving the option for the message to be public, but defaulting to DM.

GeekyDeaks commented 7 years ago

closing this as it seems to working ok now and will re-open tickets if new bugs are found