search

GeekyDeaks / discord-destinybot

Discord Destiny Bot
MIT License
8 stars 3 forks source link

Additional platforms #31

Closed itslazyvar closed 7 years ago

GeekyDeaks commented 7 years ago

Nice! This mean you are happy with people updating their own details?

I am just testing the latest version of discord.js so will push these changes at the same time. I'll also make the games bit work properly.

GeekyDeaks commented 7 years ago

One tip LMG. You should be able to specify a different branch to master when you submit the pull request. If you think you will be making more changes and worried about messing up master then I'll make an indev branch for us to use. This does mean you have to think about which branches you are working on with your instance of the bot though.

itslazyvar commented 7 years ago

Thanks for the heads up. I have yet to come up with a good way to manage different versions and instances, but perhaps you can give me some tips on that next year ;)

Op 31 dec. 2016, om 20:39 heeft Scott Deakin notifications@github.com het volgende geschreven:

One tip LMG. You should be able to specify a different branch to master when you submit the pull request. If you think you will be making more changes and worried about messing up master then I'll make an indev branch for us to use. This does mean you have to think about which branches you are working on with your instance of the bot though.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GeekyDeaks/discord-destinybot/pull/31#issuecomment-269879241, or mute the thread https://github.com/notifications/unsubscribe-auth/AE14ZjFs_u6jB9QSDp7nF0xUIcNlgBlJks5rNq-IgaJpZM4LYmGV.

GeekyDeaks commented 7 years ago

You have triggered my OCD 😄

This is not very well optimised and there are 2 other commands that display the member information - gamer and players. At present they just kick out the XBL and PSN, but I guess they should either all use some common function to display or we repeat the code in each command module.