search

GemTalk / JadeiteForPharo

IDE for GemStone Smalltalk application development in Pharo using Rowan code management
MIT License
0 stars 0 forks source link

step point markers "sticky" #109

Closed ericwinger closed 1 week ago

ericwinger commented 4 months ago

Under some as-yet-unknown conditions, the gray step point indicators shown in the method source panes are not cleared when the method is refreshed. Then the new method source's step points are "overlayed" creating visual clutter and confusion. My suspicion is that it happens during an update from another browser, but that needs to be investigated.

Opening a new browser is an effective but not very nice workaround.

ericwinger commented 4 months ago

Not sure if commit is the ultimate fix but a definite improvement.

After a method service replication, we were updating the browser's method source pane twice in JadeiteBrowserPresenter>>#updateMethodSource & RowanMethodService>>#methodSourceUpdate:browser:. By eliminating the latter method & registration, we not only have one less update to perform after a server round trip, it seems to draw the step point lines better, too. Still not sure why but I guess that it has to do with doing deferred UI updates in a non-Morphic process.

ericwinger commented 1 week ago

After a complete rework of how the JfP gui is drawn which eliminated multiple morphic threads, the problem seems to have gone away. Can reopen if it returns.