search

GemTalk / JadeiteForPharo

IDE for GemStone Smalltalk application development in Pharo using Rowan code management
MIT License
1 stars 1 forks source link

Abstract test cases show up (later) in SUnit Browser #43

Closed LisaAlmarode closed 11 months ago

LisaAlmarode commented 12 months ago

Plantis has an abstract test case with concrete subclasses. On opening the SUnit browser, I see correctly only the 5 concrete classes, but once I select any concrete class, the list is refreshed and the abstract class is listed. That's annoying but OK.

If the class I select is the one immediately below the abstract class, then the abstract class is selected, BUT it's showing the lists of tests that belong to the class I attempted to select. This causes some of the tests (the ones on the actual selected subclass) to mysteriously fail. This is VERY confusing and terrible.

PlantisTester is abstract; the one I wanted to select was PlantisUnitTester.

image

Bonus bug: if you have no classes selected, 'Run Selected' gets a walkback.

ericwinger commented 11 months ago

We were updating the test class list twice - once for test classes and once for all classes. The latter was not correct.

Fixed bonus bug in an earlier commit.