Performance improvements for `using Genie`

PallHaraldsson commented 2 years ago

A. Went from tolerable, not fast, in Julia 1.6.0:

julia> @time using Genie
  1.984320 seconds (2.42 M allocations: 157.321 MiB, 3.01% gc time, 0.33% compilation time)

to, in just released, Julia 1.7.0:

julia> @time using Genie
 19.792401 seconds (36.84 M allocations: 1.695 GiB, 5.98% gc time, 89.93% compilation time)

Precompiling was already slow, and I was hoping it would pay off:

julia> @time using Genie
[ Info: Precompiling Genie [c43c736e-a2d1-11e8-161f-af95117fbd1e]
 90.177432 seconds (36.66 M allocations: 1.691 GiB, 1.38% gc time, 19.97% compilation time)

it turned out I was on the latest version, while on v3.0.0 for Julia 1.6 and using that version is still slightly slower in 1.7:

julia> @time using Genie
  2.146188 seconds (2.69 M allocations: 155.669 MiB, 0.94% gc time, 60.14% compilation time)

for v4.0.0:

julia> @time using Genie
  3.234528 seconds (4.21 M allocations: 250.503 MiB, 2.85% gc time, 40.49% compilation time)

for v4.1.0:

julia> @time using Genie
 19.665928 seconds (36.83 M allocations: 1.694 GiB, 5.78% gc time, 90.08% compilation time)

Do you have any idea what may have caused this?

I tried on 1.6:

(@v1.6) pkg> add Genie@v4.4.1
   Resolving package versions...
ERROR: Unsatisfiable requirements detected for package Atom [c52e3926]:
 Atom [c52e3926] log:
 ├─possible versions are: 0.8.0-0.12.35 or uninstalled
 ├─restricted to versions * by an explicit requirement, leaving only versions 0.8.0-0.12.35
 ├─restricted by compatibility requirements with JuliaFormatter [98e50ef6] to versions: 0.8.0-0.8.8 or uninstalled, leaving only versions: 0.8.0-0.8.8
 │ └─JuliaFormatter [98e50ef6] log:
 │   ├─possible versions are: 0.1.0-0.19.2 or uninstalled
 │   └─restricted by compatibility requirements with Genie [c43c736e] to versions: 0.15.0-0.15.11
 │     └─Genie [c43c736e] log:
 │       ├─possible versions are: 0.9.4-4.4.1 or uninstalled
 │       └─restricted to versions 4.4.1 by an explicit requirement, leaving only versions 4.4.1
 └─restricted by compatibility requirements with Requires [ae029012] to versions: 0.12.0-0.12.35 or uninstalled — no versions left
   └─Requires [ae029012] log:
     ├─possible versions are: 0.5.0-1.1.3 or uninstalled
     └─restricted by compatibility requirements with Tullio [bc48ee85] to versions: 1.0.0-1.1.3
       └─Tullio [bc48ee85] log:
         ├─possible versions are: 0.1.0-0.3.2 or uninstalled
         └─restricted to versions * by MicroHH [9dba9f50], leaving only versions 0.1.0-0.3.2
           └─MicroHH [9dba9f50] log:
             ├─possible versions are: 0.1.0 or uninstalled
             └─MicroHH [9dba9f50] is fixed to version 0.1.0

This could be about your dependencies, since downgrading Genie on Julia 1.7 made it fast and upgrading again, made it slow again and showed:

(@v1.7) pkg> add Genie@v4.4.1
   Resolving package versions...
    Updating `~/.julia/environments/v1.7/Project.toml`
  [c43c736e] ↑ Genie v3.0.0 ⇒ v4.4.1
  [98e50ef6] ↑ JuliaFormatter v0.13.10 ⇒ v0.15.11
    Updating `~/.julia/environments/v1.7/Manifest.toml`
  [00ebfdb7] ↑ CSTParser v2.5.0 ⇒ v3.3.0
  [c43c736e] ↑ Genie v3.0.0 ⇒ v4.4.1
  [98e50ef6] ↑ JuliaFormatter v0.13.10 ⇒ v0.15.11
  [0796e94c] ↑ Tokenize v0.5.13 ⇒ v0.5.21
  [856ac37a] + UrlDownload v1.0.0
  [a637dc6b] + VersionCheck v0.2.0

I tried with an empty .julia folder so that's not it.

I'm willing to look into this, while good if first you could confirm, and let me know if you have any good ideas why.

julia> @time using JuliaFormatter
  0.991517 seconds (1.43 M allocations: 96.471 MiB, 2.66% gc time, 2.73% compilation time)

B. https://github.com/GenieFramework/Genie.jl/commit/36bf0925e1def2c94ad9cdbeecae11f9b37d2bdc

I noticed you added lower case session for:

export Session, session

I suspect you had a typo and kept upper case Session as it might be technically breaking to not keep exporting it? Or am I wrong, so far I've only seen methods exported, and I'm not sure anything else needed.

I'm just trying to learn [from] your code, and also found this intriguing:

const HTTP = HTTP