Genii-Locorum / brp

Foundry VTT implementation for Basic Role Playing
Other
14 stars 2 forks source link

I'm unable to make any rolls beside regular rolls #16

Closed LeonxnoeL closed 4 months ago

LeonxnoeL commented 4 months ago

The dialog box for opposed/combined/cooperative rolls never pop up when I select these types. Instead, this shows up in the console instead so I figured it might help you troubleshoot it:

image

Genii-Locorum commented 4 months ago

Thanks for reporting this. What version of Foundry and BRP are you using?

LeonxnoeL commented 4 months ago

Thanks for reporting this. What version of Foundry and BRP are you using?

I'm using the latest BRP version 12.1.17 and Foundry version 11 stable build 307!

LeonxnoeL commented 4 months ago

I'm something of a programmer myself but I have never really touched javascript/css/html... I have only fiddled a little with kotlin here and there but I'm having fun trying to make sense out of this issue xD. Seems to be something related to this OTHER from CHAT_MESSAGE_STYLES but I can't find where those are declared at all.

Also, if it helps, I am using the Dice So Nice! module and another module called Wooden UI which changes some of the UI, not sure if those could interfere or not.

LeonxnoeL commented 4 months ago

Also, to clarify, resistances rolls are working! It seems only opposed/combined/cooperative rolls refuse to open.

Genii-Locorum commented 4 months ago

That really helps - and I know what the problem is (or rather, what my mistake was). I've said this version of BRP is valid for version 11 - when I should have said V12 only.

You're spot on with the CHAT_MESSAGE_STYLES "OTHER", it's something that changed from V11 to V12 (they are defined in Foundry iteself rather than this system). Let me have a quick think about a fix so it can work with V11 for now and I'll look at the next version being V12 only.

Cheers

Genii-Locorum commented 4 months ago

I've just put release v18 out which hopefully solves the problem - please let me know and if it works I'll close the issue.

Cheers

LeonxnoeL commented 4 months ago

It works now! Thanks a ton.