Genii-Locorum / brp

Foundry VTT implementation for Basic Role Playing
Other
14 stars 2 forks source link

[BUG] [MINOR] Long Names on Roll Cards #30

Open Cosmic-Lattee opened 3 weeks ago

Cosmic-Lattee commented 3 weeks ago

So this is a minor issue, when you have really long names for skills or attacks the text overflows and covers the result.

image

image

Genii-Locorum commented 3 weeks ago

In check.mjs try changing line 302 to

label: config.label.substr(0,25),

See if that works for you.

Genii-Locorum commented 3 weeks ago

There's probably some wider work to look at all layouts on character sheets to do something similar or prevent wraps (there's a truncate css class in BRP)

Cosmic-Lattee commented 3 weeks ago

This works better though the displayed damage calculation is bleeding over into the roll, though it is visible at least.

image

image

Works better on the skill.

Genii-Locorum commented 3 weeks ago

OK, perhaps it's time for me to expand the various roll cards. Let me have a think about each card and think about changing the layout - but all input welcome

For example on the Damage card should it be Roll Type on one line (Damage Roll) Image - Weapon Name Image - Damage Formula Rolled Damage

In Expansion section Dice: Dice Rolled Success Label

I'll still need to limit some string lengths.