Make map full screen and responsive

GeospatialResearch / gri-earthquake

Other

1 stars 0 forks source link

Make map full screen and responsive #14

Closed LukeParky closed 3 years ago

LukeParky commented 3 years ago

Makes the map on the page responsive to window resizing and makes it full screen.
Overlays the RangeSelector component on top of the map. Implementing the functionality and improving the look & feel of this component is handled by issue #6
Refactors map initialisation into helper methods.

LukeParky commented 3 years ago

I'm not so sure about the way I have done the CSS classes/ids/selectors so any review on that would be great

rosepearson commented 3 years ago

I'm not so sure about the way I have done the CSS classes/ids/selectors so any review on that would be great

Hmm, that is beyond my area of expertise. I think your implementation is easy to follow - even if I can't comment on if it's best practice!

rosepearson commented 3 years ago

Do you expect this to respond to editing yet? Did I format the dates correctly? I think you will want to add MM/DD/YYYY or something like that to guide the user in the appropriate format.

LukeParky commented 3 years ago

The now visible selection widget looks clunky right now - but I assume this look and functionality will be the focus of a latter issue.

Yup, originally you had to scroll for that widget. I am addressing the functionality and look of that in #6. Do you think I should remove the widget from view for now?

rosepearson commented 3 years ago

The now visible selection widget looks clunky right now - but I assume this look and functionality will be the focus of a latter issue.

Yup, originally you had to scroll for that widget. I am addressing the functionality and look of that in #6. Do you think I should remove the widget from view for now?

Hi @LukeParky - that's great. I'd just edit this PR to note that the look/feel and functionality of the date selection box will be addressed in issue 6.

LukeParky commented 3 years ago

Very clear and easily understandable. Would like to comment on 3d visualizations, not sure how Z coordinates will be set.

Thank you @Pooja3894. The points I add to the map are all at sea-level right now. This is fine for now since terrain is not 3D yet. I have added an issue #18 to the tracker which deals with adding 3D terrain to the map, and in this I will ensure points added are added at ground-level.