search

GeraultTr / Root_CyNAPS

0 stars 0 forks source link

CN-Wheat converter to prepare CN-Wheat and CN-Rhizodep coupling #26

Closed GeraultTr closed 1 month ago

GeraultTr commented 1 year ago

Adapt converter from wheatfspm to allow properties' sharing between the two models to replace CN-Wheat root compartment.

GeraultTr commented 1 year ago

Created a converter function to share properties between existing modules (nitrogen, topology, soil, water, fakeshoot), but also to create a fake module which enforces collar flows with CN-Wheat outputs. However, for now it compromised the nitrogen module's stability so I have to check conflicting units or behaviors. (I'll update this issue with more details soon)

Commit 596495f and 0ee9faa

rbarillot commented 1 year ago

Hi @MTreestanG,

do we have to review a specific part of the code to solve the issue?

GeraultTr commented 1 year ago

Hi @rbarillot ,

Its actually not buggy, so if you want to see the code I'd say you can look at the simultation_no_C.py (line 30-54) and the converter.py files in the rhydromin folder if you're interested on the structure. But actually, I think my problem is coming from a unit issue. Thus maybe I should add a unit converter factor in this strategy because different modules could use variables conceptually aligned but in different units (and let's say we do not want to edit these models).

By the way, if I want to refer to a specific code portion in a Github comment, is there a more straightforward way to do this?

GeraultTr commented 1 month ago

Performed in Wheat-BRIDGES