search

GitBrincie212 / Apel-Mod

Apel is a library that brings particle animations to the table with flexible behaviour and a clean developer interface. It promises also lots of predefined shapes & paths to help the developer on their particle scene
Other
2 stars 1 forks source link

Tetrahedrons don't properly check validity #40

Closed DarthSharkie closed 2 months ago

DarthSharkie commented 2 months ago 
    public Vector3f setVertex1(Vector3f newVertex) {
        Vector3f prevVertex1 = this.vertex1;
        this.checkValidTetrahedron(vertex1, this.vertex2, this.vertex3, this.vertex4);
        this.vertex1 = newVertex;
        return prevVertex1;
    }

This checks for a valid tetrahedron made from the existing vertices, not including the updated vertex1. The check should use the new vertex.