search

GitBrincie212 / Apel-Mod

Apel is a library that brings particle animations to the table with flexible behaviour and a clean developer interface. It promises also lots of predefined shapes & paths to help the developer on their particle scene
Other
2 stars 1 forks source link

Triangles don't properly check validity #41

Closed DarthSharkie closed 2 months ago

DarthSharkie commented 2 months ago 
    public Vector3f setVertex1(Vector3f newVertex) {
        Vector3f prevVertex1 = this.vertex1;
        this.checkValidTriangle(vertex1, this.vertex2, this.vertex3);
        this.vertex1 = newVertex;
        return prevVertex1;
    }

Triangles are checking validity with the existing vertices, not the new one. They should check with the new vertex prior to setting it.